[libav-devel] [PATCH 1/2] Replace all usage of strcasecmp/strncasecmp

Luca Barbato lu_zero at gentoo.org
Fri Nov 4 19:44:47 CET 2011


On 11/4/11 11:16 AM, Måns Rullgård wrote:
> Luca Barbato<lu_zero at gentoo.org>  writes:
>
>> On 11/4/11 9:45 AM, Kostya Shishkov wrote:
>>> On Fri, Nov 04, 2011 at 04:42:11PM +0000, Måns Rullgård wrote:
>>>> Luca Barbato<lu_zero at gentoo.org>   writes:
>>>>
>>>>> On 11/4/11 9:28 AM, Måns Rullgård wrote:
>>>>>> Write it in a non-ugly way of course.
>>>>>
>>>>> Let me expand:
>>>>>
>>>>> - the strcasecmp/strncasecmp itself isn't much different than the
>>>>> usual libc implementation, the toupper can enjoy a better
>>>>> implementation (to be noted that in all libc I had a look into strcase
>>>>> uses tolower).
>>>>
>>>> Yes, that macro is what I was talking about.
>>>
>>> What about
>>>
>>> #define TOUPPER(c) \
>>>      if (c>= 'a'&&   c<= 'z') \
>>>          c ^= 0x20;
>>
>> Looks nicer.
>
> I'd make it a bit more function-like or even an inline function.
>

Do we have other uses for it (seems we are using toupper somewhere as well?

lu
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tolower.diff
URL: <http://lists.libav.org/pipermail/libav-devel/attachments/20111104/29dfab94/attachment.ksh>


More information about the libav-devel mailing list