[libav-devel] [PATCH 2/2] movdec: Set frame_size for AMR

Martin Storsjö martin at martin.st
Fri Nov 4 15:40:29 CET 2011


On Fri, 4 Nov 2011, Luca Barbato wrote:

> On 11/4/11 6:25 AM, Martin Storsjö wrote:
>> From: Carl Eugen Hoyos<cehoyos at ag.or.at>
>> 
>> The amr demuxer also sets the frame_size field.
>> ---
>
> I'd use a switch.

This actually alread is within a larger switch, with two statements being 
common to the both AMR forms, while the sample rate and frame size differ. 
Having two nested switches for the same thing looks just weird IMO, and 
duplicating the two common statements feels needless.

// Martin


More information about the libav-devel mailing list