[libav-devel] [PATCH] hwaccel: Video Decoder Acceleration (VDA) support

Janne Grunau janne-libav at jannau.net
Thu Nov 3 00:14:46 CET 2011


On Wed, Nov 02, 2011 at 11:45:31PM +0100, Diego Biurrun wrote:
> Another fresh patch with some of these suggestions already applied
> will arrive on the ml soon.
> 
> On Wed, Nov 02, 2011 at 10:44:41PM +0100, Diego Biurrun wrote:
> > 
> > --- a/libavcodec/Makefile
> > +++ b/libavcodec/Makefile
> > @@ -45,6 +45,7 @@ RDFT-OBJS-$(CONFIG_HARDCODED_TABLES)   += sin_tables.o
> >  OBJS-$(CONFIG_SINEWIN)                 += sinewin.o
> >  OBJS-$(CONFIG_VAAPI)                   += vaapi.o
> > +OBJS-$(CONFIG_VDA)                     += vda.o
> >  OBJS-$(CONFIG_VDPAU)                   += vdpau.o
> >  
> > @@ -178,6 +179,7 @@ OBJS-$(CONFIG_H264_DECODER)            += h264.o                               \
> >                                            mpegvideo.o error_resilience.o
> >  OBJS-$(CONFIG_H264_VAAPI_HWACCEL)      += vaapi_h264.o
> > +OBJS-$(CONFIG_H264_VDA_HWACCEL)        += vda_h264.o
> >  OBJS-$(CONFIG_HUFFYUV_DECODER)         += huffyuv.o
> >  OBJS-$(CONFIG_HUFFYUV_ENCODER)         += huffyuv.o
> 
> How much sense does VDA make without H.264 VDA?  It seems to me both
> should just be enabled together.

does VDA support other codecs? if yes, it can stay as is although it's
a bit silly.

> > +
> > +#define Picture QuickdrawPicture
> > +
> > +#include <pthread.h>
> > +#include <VideoDecodeAcceleration/VDADecoder.h>
> > +
> > +#include "avcodec.h"
> 
> The #define looks dangerous to me, we have a struct Picture, so I fear
> for unintended sideeffects.

assuming it is needed for <VideoDecodeAcceleration/VDADecoder.h>
undefining Picture after including it should be safe.

Janne


More information about the libav-devel mailing list