[libav-devel] [PATCH]: Video Decoder Acceleration (VDA) HWAccel module for Mac OS X

Luca Barbato lu_zero at gentoo.org
Wed Nov 2 19:32:15 CET 2011


On 11/2/11 10:20 AM, Ronald S. Bultje wrote:
> Hi,
>
> On Wed, Nov 2, 2011 at 10:18 AM, Sebastien Zwickert<dilaroga at gmail.com>  wrote:
>> On Nov 2, 2011, at 6:04 PM, Ronald S. Bultje wrote:
>>> On Wed, Nov 2, 2011 at 10:00 AM, Sebastien Zwickert<dilaroga at gmail.com>  wrote:
>>>> On Nov 2, 2011, at 5:48 PM, Ronald S. Bultje wrote:
>>>>> On Tue, Nov 1, 2011 at 7:45 AM, Sebastien Zwickert<dilaroga at gmail.com>  wrote:
>>>>> [..]
>>>>>> diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
>>>>>> index 25c9ef9..3565496 100644
>>>>>> --- a/libavutil/pixfmt.h
>>>>>> +++ b/libavutil/pixfmt.h
>>>>>> @@ -119,6 +119,8 @@ enum PixelFormat {
>>>>>>      PIX_FMT_VAAPI_IDCT, ///<  HW acceleration through VA API at IDCT entry-point, Picture.data[3] contains a vaapi_render_state struct which contains fields extracted from headers
>>>>>>      PIX_FMT_VAAPI_VLD,  ///<  HW decoding through VA API, Picture.data[3] contains a vaapi_render_state struct which contains the bitstream of the slices as well as various fields extracted from headers
>>>>>>
>>>>>> +    PIX_FMT_VDA_VLD,    ///<  HW decoding through VDA.
>>>>>> +
>>>>>>      PIX_FMT_YUV420P16LE,  ///<  planar YUV 4:2:0, 24bpp, (1 Cr&  Cb sample per 2x2 Y samples), little-endian
>>>>>>      PIX_FMT_YUV420P16BE,  ///<  planar YUV 4:2:0, 24bpp, (1 Cr&  Cb sample per 2x2 Y samples), big-endian
>>>>>>      PIX_FMT_YUV422P16LE,  ///<  planar YUV 4:2:2, 32bpp, (1 Cr&  Cb sample per 2x1 Y samples), little-endian
>>>>>
>>>>> This should go at the end, else you break ABI and (worse) isBE() in
>>>>> swscale won't behave as expected with the values below anymore.
>>>>
>>>> This has been fixed in one of the updated patches. PIX_FMT_VDA_VLD is at the end of the list.
>>>
>>> You probably sent that to ffmpeg-devel only. Want me to fetch it from
>>> there or do you want to re-send it here?
>>
>> Indeed i forgot to cc libav-devel after the first patch sent. Sorry about that.
>> The applied patch is in attachment.
>
> Thanks, patch LGTM.

I'll rework it to fit into libav soon.

lu


More information about the libav-devel mailing list