[libav-devel] [PATCH] Error out if vaapi is not found

Måns Rullgård mans at mansr.com
Mon Apr 4 00:27:05 CEST 2011


Luca Barbato <lu_zero at gentoo.org> writes:

> On 04/04/2011 12:16 AM, Måns Rullgård wrote:
>> Luca Barbato <lu_zero at gentoo.org> writes:
>> 
>>> Make the behaviour consistent with the other external deps.
>>> ---
>>>  configure |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index fab4f2b..0aae67c 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2827,7 +2827,9 @@ for thread in $THREADS_LIST; do
>>>  done
>>>  
>>>  check_lib math.h sin -lm
>>> -disabled vaapi || check_lib va/va.h vaInitialize -lva
>>> +enabled vaapi && require vaapi va/va.h vaInitialize -lva &&
>>> +                { check_cpp_condition va/va_version.h "VA_CHECK_VERSION(0,32,0)" ||
>>> +                  die "Please upgrade to VA-API >= 0.32"; }
>> 
>> You are changing the test to require a specific version.  Why?
>
> The patchset just warns if the version is incorrect I'd rather require
> the proper version.

I'm talking about this very patch.  Current git master only checks for
the library existence.  Since when do we require 0.32?  It is still
marked unstable in Gentoo, and other distributions are usually slower.

-- 
Måns Rullgård
mans at mansr.com


More information about the libav-devel mailing list