[libav-commits] rtpdec_mpeg4: au_headers is a single array, simple av_free is enough

Janne Grunau git at libav.org
Tue Oct 9 14:41:52 CEST 2012


Module: libav
Branch: master
Commit: 8dd0650fe67398d78214687b1a15e614239ff593

Author:    Janne Grunau <janne-libav at jannau.net>
Committer: Janne Grunau <janne-libav at jannau.net>
Date:      Tue Oct  9 14:24:36 2012 +0200

rtpdec_mpeg4: au_headers is a single array, simple av_free is enough

Fixes CID700204.

---

 libavformat/rtpdec_mpeg4.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)

diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c
index d3e0754..cc92c88 100644
--- a/libavformat/rtpdec_mpeg4.c
+++ b/libavformat/rtpdec_mpeg4.c
@@ -93,15 +93,7 @@ static PayloadContext *new_context(void)
 
 static void free_context(PayloadContext * data)
 {
-    int i;
-    for (i = 0; i < data->nb_au_headers; i++) {
-         /* according to rtp_parse_mp4_au, we treat multiple
-          * au headers as one, so nb_au_headers is always 1.
-          * loop anyway in case this changes.
-          * (note: changes done carelessly might lead to a double free)
-          */
-       av_free(&data->au_headers[i]);
-    }
+    av_free(data->au_headers);
     av_free(data->mode);
     av_free(data);
 }



More information about the libav-commits mailing list