[libav-commits] apetag: fix the amount of data read from binary tags.

Anton Khirnov git at libav.org
Mon Jul 2 16:22:04 CEST 2012


Module: libav
Branch: master
Commit: b72767df8e4f496da36138aa7127e408c1cde7f8

Author:    Anton Khirnov <anton at khirnov.net>
Committer: Anton Khirnov <anton at khirnov.net>
Date:      Tue Jun 26 18:54:00 2012 +0200

apetag: fix the amount of data read from binary tags.

Substract the filename size from the data size.

---

 libavformat/apetag.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/libavformat/apetag.c b/libavformat/apetag.c
index e5c839e..f8653d3 100644
--- a/libavformat/apetag.c
+++ b/libavformat/apetag.c
@@ -59,7 +59,12 @@ static int ape_tag_read_field(AVFormatContext *s)
         AVStream *st = avformat_new_stream(s, NULL);
         if (!st)
             return AVERROR(ENOMEM);
-        avio_get_str(pb, size, filename, sizeof(filename));
+
+        size -= avio_get_str(pb, size, filename, sizeof(filename));
+        if (size <= 0) {
+            av_log(s, AV_LOG_WARNING, "Skipping binary tag '%s'.\n", key);
+            return 0;
+        }
         st->codec->extradata = av_malloc(size + FF_INPUT_BUFFER_PADDING_SIZE);
         if (!st->codec->extradata)
             return AVERROR(ENOMEM);



More information about the libav-commits mailing list