[libav-bugs] [Bug 515] implement runtime CPU detection for SPARC VIS accelerations

bugzilla-daemon at aruru.libav.org bugzilla-daemon at aruru.libav.org
Sun May 19 16:37:56 CEST 2013


https://bugzilla.libav.org/show_bug.cgi?id=515

--- Comment #7 from Diego Biurrun <diego at biurrun.de> 2013-05-19 16:37:56 CEST ---
Comment on attachment 409
  --> https://bugzilla.libav.org/attachment.cgi?id=409
proof of concept

>--- a/libavutil/cpu.c
>+++ b/libavutil/cpu.c
>@@ -90,6 +91,8 @@
>         { "neon",     NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AV_CPU_FLAG_NEON     },    .unit = "flags" },
>+#elif ARCH_SPARC
>+        { "vis"     , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AV_CPU_FLAG_VIS      },    .unit = "flags" },

Keep the comma directly after the string.

>@@ -126,6 +129,8 @@
>     { AV_CPU_FLAG_NEON,      "neon"       },
> #elif ARCH_PPC
>     { AV_CPU_FLAG_ALTIVEC,   "altivec"    },
>+#elif ARCH_SPARC
>+    { AV_CPU_FLAG_ALTIVEC,   "vis"        },

This is a copy and paste typo, the flag should be for VIS.

In general this looks pretty decent.  Can you make it a proper git patch and
send it to the mailing list?

-- 
Configure bugmail: https://bugzilla.libav.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the libav-bugs mailing list