[libav-bugs] [Bug 265] smacker audio decode regression

bugzilla-daemon at aruru.libav.org bugzilla-daemon at aruru.libav.org
Fri Mar 30 17:07:22 CEST 2012


https://bugzilla.libav.org/show_bug.cgi?id=265

--- Comment #3 from Franz Brauße <dev at karlchenofhell.org> 2012-03-30 17:07:22 CEST ---
http://git.libav.org/?p=libav.git;a=commitdiff;h=c86c3c8017da512591e6a490d447f64dc3d9253f

and 

http://git.libav.org/?p=libav.git;a=commitdiff;h=818a3bdedffedcc131a00f57d12597e5b7e054e6

work. The last other changing how *samples++ is stored, breaks the decode.

So, I tried (in the 16-bit-path):
1) *samples++ = pred[0];
2) *samples++ = pred[0] & 0xffff;
3) *samples++ = av_clip_int16(pred[0]);
4) *samples++ = av_clip_uint16(pred[0]);
5) *samples++ = av_clip_uint8(pred[0]);

1) is like 0.7.4 and works nicely
2) is the same as 1), just explicitely written and works as well
3) exhibits the behaviour described above due to it being the code from 0.8
4) sounds a little better, but there is some distortion not present in 1) or 2)
5) much too quiet, same distortions as above (since it is 16-bit data, not
8-bit)

-- 
Configure bugmail: https://bugzilla.libav.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the libav-bugs mailing list