[libav-bugs] [Bug 264] New: avprobe/ffprobe: checking return value of void function

bugzilla-daemon at aruru.libav.org bugzilla-daemon at aruru.libav.org
Thu Mar 29 12:47:12 CEST 2012


           Summary: avprobe/ffprobe: checking return value of void
           Product: Libav
           Version: git HEAD
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: utilities
        AssignedTo: bugzilla at libav.org
        ReportedBy: mad+libav at programmfabrik.de

(found the problem in 0.7.3, but the code is still buggy in current git HEAD)

in avprobe.c:

static void opt_pretty(void)
    { "pretty", 0, {(void*)&opt_pretty},
      "prettify the format of displayed values, make it more human readable" },

in cmdutils.c:

   } else if (po->u.func_arg) {
        int ret = po->flags & OPT_FUNC2 ? po->u.func2_arg(optctx, opt, arg)
                                        : po->u.func_arg(opt, arg);
        if (ret < 0) {
            av_log(NULL, AV_LOG_ERROR,
                   "Failed to set value '%s' for option '%s'\n", arg, opt);
            return ret;

at least on i386 this resulted in a non-working option for our build of 0.7.3.
amd64 worked fine, but only by accident.

Configure bugmail: https://bugzilla.libav.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the libav-bugs mailing list