[libav-devel] [PATCH 4/5] build: Consistently handle conditional compilation for all optimization OBJS.

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> ---
>  common.mak              |    6 +++++-
>  libavcodec/arm/Makefile |   11 ++++-------
>  libavcodec/ppc/Makefile |    3 +--
>  libavcodec/x86/Makefile |    6 +++---
>  4 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/common.mak b/common.mak
> index d781ced..b62efb6 100644
> --- a/common.mak
> +++ b/common.mak
> @@ -5,7 +5,11 @@
>  # first so "all" becomes default target
>  all: all-yes
>
> -OBJS-$(HAVE_MMX) +=  $(MMX-OBJS-yes)
> +OBJS-$(HAVE_ALTIVEC) += $(ALTIVEC-OBJS) $(ALTIVEC-OBJS-yes)
> +OBJS-$(HAVE_ARMV6)   += $(ARMV6-OBJS) $(ARMV6-OBJS-yes)
> +OBJS-$(HAVE_ARMVFP)  += $(ARMVFP-OBJS) $(ARMVFP-OBJS-yes)
> +OBJS-$(HAVE_MMX)     += $(MMX-OBJS) $(MMX-OBJS-yes) $(YASM-OBJS) $(YASM-OBJS-yes)
> +OBJS-$(HAVE_NEON)    += $(NEON-OBJS) $(NEON-OBJS-yes)

I don't like arch-specific things creeping into generic code like this.

-- 
Måns Rullgård
mans at mansr.com