[libav-devel] [PATCH] dsputil: remove debug message in dsputil_init().

[Ronald S. Bultje]

Hi,

On Wed, Aug 10, 2011 at 10:41 AM, Justin Ruggles
<justin.ruggles at gmail.com> wrote:
> On 08/10/2011 01:03 PM, Ronald S. Bultje wrote:
>
>> Hi,
>>
>> On Wed, Aug 10, 2011 at 6:42 AM, Justin Ruggles
>> <justin.ruggles at gmail.com> wrote:
>>> AVCodecContext.bits_per_raw_sample is used for audio too, and values other
>>> than 8, 9, and 10 are valid.
>>> ---
>>>  libavcodec/dsputil.c |    2 --
>>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c
>>> index d318601..34b1a8c 100644
>>> --- a/libavcodec/dsputil.c
>>> +++ b/libavcodec/dsputil.c
>>> @@ -3100,8 +3100,6 @@ av_cold void dsputil_init(DSPContext* c, AVCodecContext *avctx)
>>>         }
>>>         break;
>>>     default:
>>> -        av_log(avctx, AV_LOG_DEBUG, "Unsupported bit depth: %d\n", avctx->bits_per_raw_sample);
>>> -    case 8:
>>>         BIT_DEPTH_FUNCS(8, _16);
>>
>> if (avctx->codec->codec_type == AVMEDIA_TYPE_VIDEO) abort()? It's a
>> bug if it's unset or invalid for video.
>
>
> Then there are lots of bugs...
>
> e.g. conversion rm30 to mjpeg:
> [mjpeg @ 0x2201ea0] Unsupported bit depth: 0
> [rv30 @ 0x220a200] Unsupported bit depth: 0

After having a closer look, you're right. So patch LGTM.

Ronald