[libav-devel] [PATCH 1/2] Replace all usage of strcasecmp/strncasecmp

[Martin Storsjö]

On Fri, 4 Nov 2011, Luca Barbato wrote:

> On 11/4/11 3:46 PM, Martin Storsjö wrote:
>> On Fri, 4 Nov 2011, Luca Barbato wrote:
>> 
>>> On 11/4/11 11:16 AM, Måns Rullgård wrote:
>>>> 
>>>> I'd make it a bit more function-like or even an inline function.
>>>> 
>>> 
>>> Do we have other uses for it (seems we are using toupper somewhere as
>>> well?
>> 
>> Yes, I think it might be useful in most (all?) other places, too.
>> 
>> If it's kept as a static inline function, I don't like av_ as prefix for
>> it, since it tells me that it is an external function. Not sure what
>> would be better though (and something is necessary), since ff_ has a
>> certain meaning, too. ascii_toupper() perhaps? OTOH, if it's made a
>> public function, av_ is the right prefix of course.
>> 
>
> I guess we could stick it in the public header as static inline and be done 
> with that.

Yes, that might be a good idea.

// Martin