[libav-devel] [PATCH 02/11] AVOptions: add av_opt_find() as a replacement for av_find_opt.

Ronald S. Bultje rsbultje at gmail.com
Thu Jun 9 15:53:00 CEST 2011


Hi,

On Thu, Jun 9, 2011 at 9:17 AM, Justin Ruggles <justin.ruggles at gmail.com> wrote:
> On 06/09/2011 06:27 AM, Anton Khirnov wrote:
>
>> +const AVOption *av_opt_find(void *obj, const char *name, const char *unit,
>> +                            int opt_flags, int search_flags)
>> +{
>> +    AVClass *c = *(AVClass**)obj;
>> +    const AVOption *o = NULL;
>> +
>> +    if (c->opt_find && search_flags & AVOPT_SEARCH_CHILDREN &&
>> +        (o = c->opt_find(obj, name, unit, opt_flags, search_flags)))
>> +        return o;
>> +
>> +    while ((o = av_next_option(obj, o))) {
>
>
> extra unneeded parentheses.

No, these are needed: =, not ==.

Ronald


More information about the libav-devel mailing list